:) When I looked at activate_nav_tab, it looked really out of place compared to the rest of your JS code, I almost had the same feeling when I look at Rails applications and I see this ugly stub of onclick="" when Prototype is supposed to be unobtrusive. So I figured it must have been some sort of "migration" going one :|
Normally I'm sort of lazy whenever I see shuddering code like this, first I feel like I need to blog it, then I get too lazy to provide constructive criticism (real code snippets and how they should be fixed), and in the end I simply get too lazy to do the whole post and I just trash it. Constructive criticism really is a good thing, I guess.
:) When I looked at
:) When I looked at activate_nav_tab, it looked really out of place compared to the rest of your JS code, I almost had the same feeling when I look at Rails applications and I see this ugly stub of
onclick=""when Prototype is supposed to be unobtrusive. So I figured it must have been some sort of "migration" going one :|Normally I'm sort of lazy whenever I see shuddering code like this, first I feel like I need to blog it, then I get too lazy to provide constructive criticism (real code snippets and how they should be fixed), and in the end I simply get too lazy to do the whole post and I just trash it. Constructive criticism really is a good thing, I guess.